[docs] Correctly configure Vale#244
Merged
oliviertassinari merged 1 commit intomasterfrom Sep 19, 2024
Merged
Conversation
oliviertassinari
force-pushed
the
vale
branch
from
86c46c0 to
e92a280
Compare
mapache-salvaje
approved these changes
Sep 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vale wasn't configured correctly during this repository creation. Running:
shouldn't crash. I fixed the problems at the same time. I have noticed having a quick look at mui/material-ui#43395.
cc @alelthomas I don't know if you get exposed to Vale in the past https://vale.sh/. We are trying to encode as many writing style rule we have as possible so engineers have good guiderails when writing docs.